Skip to content

Comments

Restyle java files under auth/http dir#2821

Closed
stephen-crawford wants to merge 2 commits intoopensearch-project:mainfrom
stephen-crawford:styleAuthHttp
Closed

Restyle java files under auth/http dir#2821
stephen-crawford wants to merge 2 commits intoopensearch-project:mainfrom
stephen-crawford:styleAuthHttp

Conversation

@stephen-crawford
Copy link
Contributor

Description

Updates all java files under **/auth/http.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #2821 (89ea0b2) into main (5f9c90b) will decrease coverage by 0.02%.
The diff coverage is 55.75%.

@@             Coverage Diff              @@
##               main    #2821      +/-   ##
============================================
- Coverage     61.61%   61.59%   -0.02%     
- Complexity     3413     3416       +3     
============================================
  Files           266      266              
  Lines         18893    18908      +15     
  Branches       3305     3302       -3     
============================================
+ Hits          11640    11646       +6     
- Misses         5656     5668      +12     
+ Partials       1597     1594       -3     
Impacted Files Coverage Δ
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 58.42% <0.00%> (ø)
...ic/auth/http/kerberos/HTTPSpnegoAuthenticator.java 0.00% <0.00%> (ø)
...azon/dlic/auth/http/kerberos/util/JaasKrbUtil.java 0.00% <0.00%> (ø)
...zon/dlic/auth/http/kerberos/util/KrbConstants.java 0.00% <0.00%> (ø)
.../dlic/auth/http/saml/SamlHTTPMetadataResolver.java 62.96% <ø> (ø)
.../main/java/com/amazon/dlic/auth/ldap/LdapUser.java 85.71% <ø> (ø)
...c/auth/ldap/backend/LDAPAuthenticationBackend.java 81.73% <ø> (ø)
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java 57.81% <ø> (ø)
...on/dlic/auth/ldap2/LDAPAuthenticationBackend2.java 67.96% <ø> (ø)
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <ø> (ø)
... and 118 more

... and 1 file with indirect coverage changes

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@stephen-crawford
Copy link
Contributor Author

Closing since #2823 got merged and contains these changes.

@stephen-crawford stephen-crawford deleted the styleAuthHttp branch June 5, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants